How long/short should a passphrase be?

Up to 149 characters but a much shorter passphrase is sufficient. Please see this great post by Trezor.